Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing Session UI/UX fixes #333

Merged
merged 10 commits into from
Feb 20, 2025
Merged

Testing Session UI/UX fixes #333

merged 10 commits into from
Feb 20, 2025

Conversation

rstijerina
Copy link
Contributor

Overview:

Various UI/UX fixes from the Feb 18 testing session.

PR Status:

  • Ready.

Related Jira tickets:

Summary of Changes:

  • add loading spinner on login callback layout
  • public project links now stay within container when long
  • public project links now link directly to the project, with no panel selected
  • delete map modal and questionnaire modal refactored to antd; close button fixed.
  • refactor datepicker to antd; add visually clear tooltip
  • fix re-render issue on filter change
  • add bottom margin to asset detail in order to show leaflet zoom buttons

Testing Steps:

  1. Test each of the above and ensure they work as expected

UI Photos:

Screenshot 2025-02-19 at 1 01 31 PM
Screenshot 2025-02-19 at 1 33 31 PM
Screenshot 2025-02-19 at 1 33 43 PM
Screenshot 2025-02-19 at 5 19 37 PM
Screenshot 2025-02-19 at 5 30 26 PM

Notes:

Do we like the asset panel solution to make sure the leaflet zoom buttons are visible?

nathanfranklin
nathanfranklin reviewed Feb 20, 2025
View reviewed changes
react/src/hooks/features/useFeatures.ts
},
],
options: { ...defaultQueryOptions, ...options },
params: queryParams,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nathanfranklin
Copy link
Collaborator

Do we like the asset panel solution to make sure the leaflet zoom buttons are visible?

I like it.

nathanfranklin
nathanfranklin approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@nathanfranklin nathanfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

just one comment about a package that can be dropped

@rstijerina rstijerina merged commit f96b7aa into main Feb 20, 2025
5 checks passed
@rstijerina rstijerina deleted the task/post-feb-test-ui-fixes branch February 20, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanfranklin nathanfranklin nathanfranklin approved these changes

@taoteg taoteg Awaiting requested review from taoteg

@sophia-massie sophia-massie Awaiting requested review from sophia-massie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rstijerina @nathanfranklin